Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable img lazyload if Incito is lazyloaded #235

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

jrlarano
Copy link
Contributor

@jrlarano jrlarano commented Jun 6, 2024

No description provided.

@jrlarano jrlarano requested review from mortenbo and klarstrup June 6, 2024 09:47
Copy link
Member

@klarstrup klarstrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the purpose of this: I would remove the options and make this the default behavior specifically for incito embed loads ie. at the this.renderHtml(res) call in the embed loading code

@jrlarano jrlarano requested review from mortenbo and klarstrup June 6, 2024 11:27
@@ -866,6 +866,7 @@ export default class Incito extends MicroEvent<{
if (res.status === 200) return res.json();
})
.then((res) => {
this.canLazyload = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the solution I had in mind, but I can see the appeal 😁

@klarstrup klarstrup merged commit fab0e78 into develop Jun 6, 2024
5 checks passed
@jrlarano jrlarano mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants